Skip to content

GitHub Issue 1082: Server exception "Badly formatted list of strings" on assay run import with invalid MVTC field value #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XingY merged 3 commits into from
Apr 23, 2026
Merged

GitHub Issue 1082: Server exception "Badly formatted list of strings" on assay run import with invalid MVTC field value #7614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e5b060
GitHub Issue 1082: Server exception "Badly formatted list of strings"…
XingY Apr 22, 2026
ca8b96d
fix comment
XingY Apr 22, 2026
4d529d5
Merge branch 'develop' into fb_issue1082
XingY Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions api/src/org/labkey/api/assay/AbstractAssayTsvDataHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,8 +866,17 @@ else if (entry.getKey().equalsIgnoreCase(ProvenanceService.PROVENANCE_INPUT_PROP
Object o = map.get(pd.getName());
if (PropertyType.MULTI_CHOICE == pd.getPropertyType())
{
o = MultiChoice.Converter.getInstance().convert(MultiChoice.Array.class, o);
map.put(pd.getName(), o);
try
{
// GitHub Issue 1082: Server exception "Badly formatted list of strings" on assay run import with invalid MVTC field value
o = MultiChoice.Converter.getInstance().convert(MultiChoice.Array.class, o);
map.put(pd.getName(), o);
}
catch (ConversionException e)
{
errors.add(new PropertyValidationError(e.getMessage(), pd.getName()));
}

}
else if (o instanceof String)
{
Expand Down
17 changes: 17 additions & 0 deletions experiment/src/client/test/integration/AssayImportRunAction.ispec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,23 @@ describe('assay-importRun.api', () => {
expect(response.text).toContain('One or more values cannot be removed from the multi-choice list');
});

// GitHub Issue 1082: Server exception "Badly formatted list of strings" on assay run import with invalid MVTC field value
it('illegal tsv string', async () => {
if (!supportMultiChoice) {
return;
}

const { topFolderOptions } = context;

// Import a run with ['Abnormal', 'cDNA'] as multi-choice values
const importPayload: ImportRunOptions = {
assayId: ASSAY_A_ID,
dataRows: [{ [RESULT_MVTC_FIELD_NAME]: ['""x,y""'] }],
};
const importResponse = await importRunToServer(server, importPayload, topFolderOptions);
expect(importResponse.body.exception).toContain('for field \'' + RESULT_MVTC_FIELD_NAME + '\' is invalid.');
});

// GitHub Issue 925: Not providing a MVTC value in an assay result throws error
it('errors when required MVTC column not provided in assay import', async () => {
if (!supportMultiChoice) {
Expand Down
Loading