Skip to content

Reimplement GWT assay plate designer in React #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-jeckels wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Reimplement GWT assay plate designer in React #7623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b0ca7b8
Switch from GWT to React
labkey-jeckels Apr 25, 2026
ca99f5e
Auto code review and comments
labkey-jeckels Apr 25, 2026
a4b284f
Test fixes
labkey-jeckels Apr 25, 2026
0622405
Other cleanup
labkey-jeckels Apr 25, 2026
19e61e8
Improve generics for plate code
labkey-jeckels Apr 27, 2026
136e9f8
Merge branch 'refs/heads/develop' into fb_reactPlateDesigner
labkey-jeckels Apr 28, 2026
a912417
Unit tests and other improvements
labkey-jeckels Apr 28, 2026
6851d9c
Another checkpoint
labkey-jeckels Apr 28, 2026
6eea87a
Merge branch 'develop' into fb_reactPlateDesigner
labkey-jeckels Apr 29, 2026
28daef7
Code review improvements, generics updates
labkey-jeckels Apr 29, 2026
82f1f83
Unit test fixup, bounds validation
labkey-jeckels Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assay/api-src/org/labkey/api/assay/plate/Plate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ public interface Plate extends PropertySet, Identifiable

@Nullable WellGroup getWellGroup(int rowId);

@NotNull List<WellGroup> getWellGroups();
@NotNull List<? extends WellGroup> getWellGroups();

@NotNull List<WellGroup> getWellGroups(Position position);
@NotNull List<? extends WellGroup> getWellGroups(Position position);

@NotNull List<WellGroup> getWellGroups(WellGroup.Type type);
@NotNull List<? extends WellGroup> getWellGroups(WellGroup.Type type);

@NotNull Map<WellGroup.Type, Map<String, WellGroup>> getWellGroupMap();

Expand Down
2 changes: 1 addition & 1 deletion assay/api-src/org/labkey/api/assay/plate/PlateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ static PlateService get()
*/
@Nullable Plate getPlate(ContainerFilter cf, Long plateSetId, Object plateIdentifier);

@NotNull List<Plate> getPlates(Container container);
@NotNull List<? extends Plate> getPlates(Container container);

/**
* Gets the plate set by ID
Expand Down
2 changes: 1 addition & 1 deletion assay/api-src/org/labkey/api/assay/plate/PlateSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public interface PlateSet extends Identifiable

boolean isTemplate();

List<Plate> getPlates();
List<? extends Plate> getPlates();

PlateSetType getType();

Expand Down
Loading
Loading