Skip to content

Fix for SMEditableGridTest.testDragFillReadOnlyColumn#2969

Open
DariaBod wants to merge 3 commits intodevelopfrom
fb_fixDragFillGrid
Open

Fix for SMEditableGridTest.testDragFillReadOnlyColumn#2969
DariaBod wants to merge 3 commits intodevelopfrom
fb_fixDragFillGrid

Conversation

@DariaBod
Copy link
Copy Markdown
Contributor

@DariaBod DariaBod commented Apr 28, 2026

Rationale

Test SMEditableGridTest.testDragFillReadOnlyColumn failing with the error "Drag is initializing in the wrong column".

Related Pull Requests

Changes

  • Added retry after dragToCell

Copy link
Copy Markdown
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This retry doesn't know enough to replicate the initial state. It assumes that a single cell is selected, which is not always the case.
In order to be able to do a retry, a method would the start and end point of the selection area. Most calls to dragFill are preceded by a call to selectCellRange. You could overload dragFill to include the selectCellRange step and retry if it fails. Something like this:

public void dragFill(WebElement selectStart, WebElement selectEnd, WebElement dragEnd)
{
    selectCellRange(selectStart, selectEnd);
    dragFill(selectEnd, dragEnd);
    /*
     check result and retry if necessary
     */
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants