Fix for SMEditableGridTest.testDragFillReadOnlyColumn#2969
Open
Fix for SMEditableGridTest.testDragFillReadOnlyColumn#2969
Conversation
labkey-tchad
approved these changes
Apr 28, 2026
Member
labkey-tchad
left a comment
There was a problem hiding this comment.
This retry doesn't know enough to replicate the initial state. It assumes that a single cell is selected, which is not always the case.
In order to be able to do a retry, a method would the start and end point of the selection area. Most calls to dragFill are preceded by a call to selectCellRange. You could overload dragFill to include the selectCellRange step and retry if it fails. Something like this:
public void dragFill(WebElement selectStart, WebElement selectEnd, WebElement dragEnd)
{
selectCellRange(selectStart, selectEnd);
dragFill(selectEnd, dragEnd);
/*
check result and retry if necessary
*/
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Test SMEditableGridTest.testDragFillReadOnlyColumn failing with the error "Drag is initializing in the wrong column".
Related Pull Requests
Changes