Accessibility improvements: add missing labels for input fields#2970
Open
labkey-susanh wants to merge 7 commits intodevelopfrom
Open
Accessibility improvements: add missing labels for input fields#2970labkey-susanh wants to merge 7 commits intodevelopfrom
labkey-susanh wants to merge 7 commits intodevelopfrom
Conversation
…uts (e.g., StoredAmount and Units)
… setters to use helpers in abstract EntityBulkDialog
labkey-susanh
commented
Apr 29, 2026
| return elementCache().formRowByControlLabel(fieldLabel); | ||
| } | ||
|
|
||
| public Pair<String, String> getAmountUnit() |
Contributor
Author
There was a problem hiding this comment.
Maybe getAmountAndUnitsReadOnlyValues or something to distinguish it from getAmountUnitValue.
This could also return a record instead of a pair for better readability, but not necessary.
| return new Pair<>(amountVal, unitVal); | ||
| } | ||
|
|
||
| public Pair<String, String> getAmountUnitValue() |
Contributor
Author
There was a problem hiding this comment.
getAmountAndUnitsValues? or getAmountAndUnitsEditableValues?
| return new Pair<>(amountVal, unitVal); | ||
| } | ||
|
|
||
| public void enableAmountUnit() |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| public void enableAmountUnit() | |
| public void enableAmountAndUnits() |
| } | ||
| } | ||
|
|
||
| public void disableAmountUnit() |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| public void disableAmountUnit() | |
| public void disableAmountAndUnits() |
| if (toggle != null && !toggle.isOn()) | ||
| { | ||
| toggle.set(true); | ||
| _changeCounter++; |
Contributor
Author
There was a problem hiding this comment.
Is _changeCounter meant to increment by only one when potentially both fields are updated?
| public void disableAmountUnit() | ||
| { | ||
| ToggleButton toggle = new ToggleButton.ToggleButtonFinder(getDriver()).findOrNull(getAmountUnitsRow()); | ||
| if(toggle != null && toggle.isOn()) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if(toggle != null && toggle.isOn()) | |
| if (toggle != null && toggle.isOn()) |
| } | ||
|
|
||
| if (amount != null && unit != null) | ||
| _changeCounter++; |
Contributor
Author
There was a problem hiding this comment.
Same question here about whether this is one change or two.
| protected abstract class ElementCache extends ModalDialog.ElementCache | ||
| { | ||
| protected final Locator textInputLoc = Locator.tagWithAttribute("input", "type", "text"); | ||
| protected final Locator checkBoxLoc = Locator.tagWithAttribute("input", "type", "checkbox"); |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| protected final Locator checkBoxLoc = Locator.tagWithAttribute("input", "type", "checkbox"); | |
| protected final Locator checkboxLoc = Locator.tagWithAttribute("input", "type", "checkbox"); |
| return new FilteringReactSelect(formRow(fieldIdentifier), getDriver()); | ||
| } | ||
|
|
||
| public Checkbox checkBox(CharSequence fieldIdentifier) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| public Checkbox checkBox(CharSequence fieldIdentifier) | |
| public Checkbox checkbox(CharSequence fieldIdentifier) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
For better accessibility of our input forms, we need to provided proper labels for each field and not label things that aren't input fields.
Related Pull Requests
Changes
EntityBulkDialogcomponent with specialized methods for the Amounts and Units row with two input fields.