Skip to content

[PLT-0] update test assets#2055

Open
mrobers1982 wants to merge 1 commit intodevelopfrom
mrobers1982/PLT_0_test_assets
Open

[PLT-0] update test assets#2055
mrobers1982 wants to merge 1 commit intodevelopfrom
mrobers1982/PLT_0_test_assets

Conversation

@mrobers1982
Copy link
Copy Markdown
Contributor

@mrobers1982 mrobers1982 commented Apr 28, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

Note

Low Risk
Test-only changes that swap referenced remote fixtures; risk is limited to potential test flakiness if the new hosted assets/URLs are unavailable or differ in format.

Overview
Switches test fixtures and integration tests to use a new set of hosted media assets (video/audio/HTML/text/PDF/conversational and a segmentation mask), including updating image_url to use IMG_URL instead of a dedicated maskable image.

Removes the unused llm_human_preference_data_row_factory fixture and updates PDF URL references used in data-row update/upsert attachment assertions.

Reviewed by Cursor Bugbot for commit 3b68e3a. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3b68e3a. Configure here.

{
"mask": {
"instanceURI": "https://storage.googleapis.com/labelbox-datasets/image_sample_data/raster_seg.png",
"instanceURI": "https://storage.googleapis.com/lb-test-data/cataflow/media/dog.png",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Segmentation mask replaced with regular photo image

Medium Severity

The segmentation mask instanceURI was changed from raster_seg.png (a purpose-built binary segmentation mask) to dog.png (likely a regular photograph). Segmentation masks work by using colorRGB (here (255, 255, 255)) to identify which pixels belong to the segmented region. A regular dog photo is unlikely to have meaningful pure-white pixels, resulting in an empty or nonsensical segmentation — potentially causing test failures or silently making the tests meaningless.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3b68e3a. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure it matters for this test - let's see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants