Conversation
…sCrypt#1457 - LabsCrypt#1441: close_stream storage reclamation with StreamClosed event - LabsCrypt#1453: SDK FlowFiClient + signers + builder + simulation pipeline - LabsCrypt#1456: ephemeral PR preview envs with seeded DB + auto-teardown - LabsCrypt#1457: ADRs + STRIDE threat model linked from README
- contracts: cargo fmt (lib.rs import wrap, test assert wraps) - preview: migrate deploy with db-push fallback (init migration fails on fresh DB) + prisma generate, matching Backend CI
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the four issues assigned to me. No builds/tests/package installs were run per instructions — implementation only.
#1441 — Storage Deposit Reclamation & State Pruning
close_stream(caller, stream_id)entrypoint incontracts/stream_contract/src/lib.rs: auth sender/recipient/admin, requires terminal inactive state with zero balance,remove()sDataKey::Stream(id), emitsStreamClosed.storage.rs: newremove_streamhelper;events.rs: newStreamClosedEvent;errors.rs: newStreamError::StreamStillActive = 17.get_stream == None.#1453 — TypeScript SDK Client-Side Signing & Tx Builder
packages/flowfi-sdk/src/client.ts(FlowFiClient),src/builder.ts(envelope builders +simulateTransactionassembly + fee-buffer padding),src/signers/index.ts(FreighterSigner/KeypairSigner/CustomSigner),src/types.ts,src/index.ts.packages/flowfi-sdk/tests/client.test.tswith mocked RPC/signer shims covering builders, simulation, fee padding, signers, and all client methods.#1456 — PR Preview Ephemeral Environments
.github/workflows/pr-preview.yml: per-PR Postgres (flowfi_preview_pr_<N>or Neon/Supabase branch),prisma migrate deploy+ seed, backend + frontend preview builds, Fly deploy whenFLY_API_TOKENset, bot comment with preview/health URLs..github/workflows/pr-preview-cleanup.yml: auto-teardown on PR close.scripts/deploy-preview.sh/scripts/cleanup-preview.sh: provider-agnostic provision/migrate/seed/deploy/health-check/teardown (executable).#1457 — ADRs & STRIDE Threat Model
docs/adr/README.md+0001TTL strategy,0002keeper-key deprecation,0003indexer cursor/dead-letter,0004SSE/WebSocket coexistence (MADR format, grounded in current code).docs/security/STRIDE_THREAT_MODEL.md: 4 trust boundaries, full S/T/R/I/D/E matrix with mitigations + residual risks.README.mdlinks ADRs, STRIDE, SDK, and preview workflows for audit accessibility.Closes #1453
Closes #1457
Closes #1456
Closes #1441