Repository navigation
Conversation
Stop pinning a copy of every engine default in this binding. The JS Database constructor now defaults all settings to null, and the native layer starts from SystemConfig() and only applies values that are neither null nor undefined. Unset settings follow engine-side default changes automatically. Explicitly passed values behave exactly as before. BREAKING CHANGE: Database() settings parameters changed from concrete defaults to null meaning "engine default".
Homebrew now also ships openssl@4, which CMake would otherwise prefer, but the top-level CMakeLists enforces OpenSSL 3 via a version guard. Mirror ci-workflow.yml: install openssl@3 and export OPENSSL_ROOT_DIR.
adsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of pinning a copy of every engine default in this binding, the JS
Databaseconstructor now defaults all settings tonull, and the native layer starts fromSystemConfig()and only applies values that are neither null nor undefined (null guards added for all 9 settings).Unset settings follow engine-side default changes automatically (e.g. LadybugDB/ladybug#1435 needs no binding change). Explicitly passed values behave exactly as before. Note: this binding never exposed
enable_multi_writes/max_num_threads, so those were already engine-controlled.BREAKING CHANGE:
Database()settings parameters changed from concrete defaults to null meaning "engine default".