Skip to content

Disable cached physical-plan reuse for parameterized write statements #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericyuanhui wants to merge 1 commit into from
Closed

Disable cached physical-plan reuse for parameterized write statements #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/client_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,11 @@ std::unique_ptr<QueryResult> ClientContext::executeWithParams(PreparedStatement*
if (!preparedStatement->isSuccess()) {
return QueryResult::getQueryResultWithError(preparedStatement->errMsg);
}
const auto useCachedPlan = preparedStatement->canReuseCachedPlanWith(inputParams);
// Physical-plan reuse is currently safe only for read-only statements. Write operators can
// project transaction-local IDs (for example, MERGE relation IDs consumed by a following
// SET), which must not survive into the next auto-commit transaction.
const auto useCachedPlan =
preparedStatement->isReadOnly() && preparedStatement->canReuseCachedPlanWith(inputParams);
try {
bindParametersNoLock(*preparedStatement, inputParams);
} catch (std::exception& e) {
Expand All @@ -399,7 +403,8 @@ std::unique_ptr<QueryResult> ClientContext::executeWithParams(PreparedStatement*
prepareNoLock(cachedStatement->parsedStatement, false /*shouldCommitNewTransaction*/,
preparedStatement->parameterMap);
useInternalCatalogEntry_ = false;
return executeNoLock(newPreparedStatement.get(), newCachedStatement.get(), queryID, {}, true);
return executeNoLock(newPreparedStatement.get(), newCachedStatement.get(), queryID, {},
preparedStatement->isReadOnly());
}

std::unique_ptr<QueryResult> ClientContext::query(std::string_view query,
Expand Down
Loading