Regenerate V2 client for Annotations & Stamps surface#60
Open
bzajzon-laserfiche wants to merge 3 commits into
Open
Regenerate V2 client for Annotations & Stamps surface#60bzajzon-laserfiche wants to merge 3 commits into
bzajzon-laserfiche wants to merge 3 commits into
Conversation
Adds AnnotationsClient and StampsClient (from the server's [OpenApiTag] split): annotation read/write (polymorphic Annotation + 14 subtypes), annotation reasons CRUD, attachment/image binary uploads, and the stamp catalog. Extends swagger-override.json with the Annotation discriminator block (propertyName annotationType + 14-subtype mapping) so NSwag generates real Annotation.fromJS dispatch instead of a throw-only abstract body (the same override the Entry polymorphic response needs). Prod baseUrl restored after the local regen.
…le GetStampImage scope; restore prod baseUrl)
…tting two slow error-path round-trips per test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the V2 JS client against the combined Annotations & Stamps server surface (server PR Laserfiche/site-api-repository!173492, WI #674508).
Changes
lf-repository-api-client-v2(swagger.json+index.ts) against the final annotations/stamps surface; the staleGetStampImagescopequery param is dropped.generate-client/swagger-override.jsoncarrying the polymorphicAnnotationdiscriminator override so the generated client deserializes annotation subtypes correctly.swagger.jsonservers[]andindex.tsdefaults (localhost-regen trap).CheckInCheckOutteardown to only undo/unlock when still locked, cutting two slow error-path round-trips per test.Notes
package.jsonversion bump and no publish — version bump + publish ship in a separate, manually-approved release PR after the server side merges.