Skip to content

fix(security): bump vitest to ^4.1.6#62

Merged
alexgomezlf merged 1 commit into
mainfrom
alex/fix-api-js-veraode-scan
Jun 18, 2026
Merged

fix(security): bump vitest to ^4.1.6#62
alexgomezlf merged 1 commit into
mainfrom
alex/fix-api-js-veraode-scan

Conversation

@alexgomezlf

Copy link
Copy Markdown
Contributor

Adds pnpm override for vitest to enforce >=4.1.6, patching the XSS vulnerability (CVE-2026-47428) where the otelCarrier query parameter was injected directly into an inline module script. Resolves TFS #674755.

@alexgomezlf alexgomezlf changed the title fix(security): bump vitest to ^4.1.6 to remediate CVE-2026-47428 fix(security): bump vitest to ^4.1.6 Jun 17, 2026
@bzajzon-laserfiche

bzajzon-laserfiche commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review — bump vitest to ^4.1.6

Verdict: Approve — correct, minimal, and CI-verified. Two minor cleanups worth doing before merge.

What it does

Adds vitest: ^4.1.6 to the root pnpm.overrides. This forces every workspace's vitest (declared ^4.1.2 in all four packages) to resolve to 4.1.9, clearing the Veracode flag for CVE-2026-47428 (critical XSS → RCE in vitest browser mode via an unsanitized otelCarrier query param injected as inline script; fixed in 4.1.6).

Correctness — verified

  • Root override is the standard pnpm pattern to force a security floor monorepo-wide; ^4.1.6 resolves to 4.1.9. ✅
  • Lockfile in sync (all @vitest/* snapshots → 4.1.9); CI is frozen-lockfile and build_libraries + test_libraries both pass. ✅
  • Low actual exposure: the vulnerable @vitest/browser isn't installed (browser configs use environment: 'jsdom', not real browser mode) — so this is scan-clearing rather than a reachable-path fix.

Minor cleanups before merge

  1. Drop the dummy commit to trigger build — squash it so merged history is just the one fix(security) commit.
  2. Optional consistency nit: the four package vitest specifiers still read ^4.1.2. The override makes that harmless, but bumping them to ^4.1.6 too would keep the declared dep from drifting below the override floor. Not blocking.

@bzajzon-laserfiche bzajzon-laserfiche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — correct, minimal, CI-verified. See review notes above; the two cleanups are non-blocking.

@alexgomezlf alexgomezlf force-pushed the alex/fix-api-js-veraode-scan branch 2 times, most recently from 3d5a545 to 93e6eb1 Compare June 17, 2026 21:14
- Adds pnpm override vitest ^4.1.6 in root package.json to force all
  workspace packages off vitest@4.1.5 (resolves to 4.1.9).
- Aligns devDependency specifier in all five workspace packages from
  ^4.1.2 to ^4.1.6 to match the override floor.
- Also adds overrides for other Veracode-flagged packages: ajv, glob,
  lodash, minimatch, serialize-javascript, ws, yaml, brace-expansion,
  flat-cache, form-data, js-yaml, markdown-it.
- Updates veracode-scan.yml: generates a package-lock.json from
  pnpm-lock.yaml so SourceClear can detect all workspace packages.
- Regenerates pnpm-lock.yaml accordingly.

CVE: CVE-2026-47428 (critical XSS in vitest browser runner via
unsanitized otelCarrier query param; fixed in 4.1.6)
Fixes TFS #674755

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alexgomezlf alexgomezlf force-pushed the alex/fix-api-js-veraode-scan branch from 93e6eb1 to 55fad6d Compare June 17, 2026 21:18
@alexgomezlf alexgomezlf merged commit 5fc4df0 into main Jun 18, 2026
10 checks passed
@alexgomezlf alexgomezlf deleted the alex/fix-api-js-veraode-scan branch June 18, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants