fix(orch): observe mapped handoffs during archive-plan re-entry - #27
Merged
Conversation
archive-plan discarded valid mapped-invariant executor results because _try_validate_task_handoff re-validated without observe=True or execution binding arguments. Forward those inputs so declared plan-level acceptance is no longer reported as missing. Co-authored-by: Ldsystem <Ldsystem@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
archive-plandiscarded valid mapped-invariant executor results._try_validate_task_handoffre-validated withoutobserve=Trueand without forwarding--workspace-id/--execution-id/--repository-id/--execution-runtime-root. Mapped completed handoffs raisedevidence-closure-blocked, the helper swallowedSystemExit, and declared plan-level acceptance was then reported as missing.This is WOR-74. It blocked final WorkBundle archival of WOR-65 after PR #26 merged; it is not an invocation-observation implementation failure.
Fix
evidence_capability.result: mappedbriefs, archive re-entry now callsvalidate_executor_result_for_task(..., observe=True, **_observation_kwargs(args)).set-plan-status Completed --handoffforwards the same binding arguments.This is different from #28, which observes only when all four CLI binding flags are present. That still drops a mapped handoff for the common
archive-plan --id ...path that loads the stored binding.Tests
test_archive_plan_accepts_mapped_invariant_handoff_with_harness_observationtest_archive_plan_forwards_execution_binding_into_task_revalidationLocal evidence after RED (
validated = []/acceptance ... is missing):ok: trueFull pinned suite locally: 668 passed; 1 fail / 2 errors only in
test_keep_summarizing_query.pyfrom HuggingFace SSL while downloading embeddings.Linear
plan-20260830-010) after merge + rerun in the original workspaceArchive-plan re-entry test evidence
Linear Issue: WOR-65