fix(workspace): support v4 multi-repository member additions - #29
Merged
Conversation
Owner
Author
|
An additional independent agent review of merge commit
Both were reproduced with public CLI regression tests before repair. A follow-up PR is being prepared with boundary-preserving insertion, target validation, and dependency-free runtime coverage. The prior plain-header live registration remains valid; this review corrects the earlier broader acceptance claim. This is a report of an independent agent's review, posted by the PR author, not a separate GitHub account approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
add-workspace-memberrejects every metadata-v4 multi-repository workspace, although this is the recommended non-Git workspace layout. The implementation assumes a composite root source at preflight, proposal, publication and replay, leaving no supported lifecycle for adding another source.Change
Make the existing lifecycle mode-aware. Multi-repository additions retain their mode and direct member-name binding, use device-local managed-worktree observations, and do not create a root Git repository or composite exclusions. Verify existing required members, checkout/Git-store containment, branch, remote and cleanliness before publication. Preserve adoption versus transaction-owned clone rollback and verified no-op replay. Keep single/composite behavior.
Append repository metadata within its owning YAML block even when optional fields are absent or unrelated top-level fields follow it. Update lifecycle guidance and add isolated regression coverage for adoption, replay, collisions, stale proposals, unsafe paths, invalid bindings and rollback.
Validation
git diff --checkandbin/work-bundle-skill validatepassed.All tests use isolated synthetic workspaces and local fixture remotes. No next-generation MCP implementation is included.
Independent read-only review accepted the exact committed patch with no findings.
The reviewer assessed safety, rollback ownership, compatibility and test oracles;
its skill-scenario assessment was reasoning-only, not an executed model harness.