Skip to content

馃帹 Palette: [UX improvement] Improve VideoPage accessibility - #10

Open
LeanBitLab wants to merge 1 commit into
mainfrom
palette-ux-video-page-a11y-16207020225899752533
Open

LeanBitLab wants to merge 1 commit into
mainfrom
palette-ux-video-page-a11y-16207020225899752533

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

What:

  • Added role = Role.Button to custom clickable buttons in VideoPage.kt (Play/Pause, Back, Subscribe).
  • Updated contentDescription strings for toggle buttons (Rotation, Mute, Auto-next, Loop) to be dynamic based on their state instead of static.

Why:

  • Screen reader users need explicit semantic roles to know an element is interactive like a button.
  • Toggle states are much clearer when the description matches the resulting action or state (e.g., "Unmute" vs generic "Mute").

Accessibility:

  • Ensures screen readers announce custom clickable components as Buttons.
  • Improves context and clarity for icon buttons with multiple states.

PR created automatically by Jules for task 16207020225899752533 started by @LeanBitLab

This commit improves accessibility for users relying on screen readers:
1. Adds `role = Role.Button` to custom `clickable` elements acting as buttons to ensure proper semantic announcement.
2. Updates quick action buttons (Rotation, Mute, Auto-next, Loop) to use dynamic `contentDescription` text that reflects their current state rather than a static label.
@google-labs-jules

Copy link
Copy Markdown

馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant