Skip to content

⚡ Bolt: [performance improvement] Replace eager Map allocation with loop in Cache Engine #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeanBitLab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Replace eager Map allocation with loop in Cache Engine #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/java/com/example/reddittube/ui/main/components/MinimalButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp

Expand Down
23 changes: 19 additions & 4 deletions app/src/main/java/com/example/reddittube/util/AdaptiveCacheEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,25 @@ class AdaptiveCacheEngine<K : Any, V : Any>(
val target = dynamicCapacity
val now = SystemClock.elapsedRealtime()
while (store.size > target) {
val candidate = store.filter { (k, n) ->
!isProtectedKey(k) || (now - n.lastAccessedMs > protectedTtlMs)
}.minByOrNull { computeScore(it.value, now) } ?: break
val removedNode = store.remove(candidate.key)
// Optimization: Replace eager map.filter and minByOrNull with an allocation-free loop.
// Expected Impact: Eliminates temporary Map allocations per eviction, significantly reducing
// GC overhead and O(N) memory allocation churn during cache eviction spikes.
var candidateKey: K? = null
var minScore = Double.MAX_VALUE

for ((k, n) in store) {
if (!isProtectedKey(k) || (now - n.lastAccessedMs > protectedTtlMs)) {
val score = computeScore(n, now)
if (score < minScore) {
minScore = score
candidateKey = k
}
}
}

if (candidateKey == null) break

val removedNode = store.remove(candidateKey)
if (removedNode != null) {
currentSizeBytes.addAndGet(-removedNode.sizeBytes)
}
Expand Down
Loading