Repository navigation
π‘οΈ Sentinel: [security improvement] Disable app backups and cleartext traffic - #13
LeanBitLab wants to merge 1 commit into
Conversation
β¦ traffic Disabled `allowBackup` and set `usesCleartextTraffic="false"` in `AndroidManifest.xml` to prevent extraction of OAuth tokens and sensitive caches via adb/Drive backups, and to protect against MITM attacks. Cleaned up ambiguous `Role` imports in `MinimalButton.kt` and fixed API level lint errors for `themes.xml`.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: The app implicitly allowed backups (
allowBackup="true"by default) and cleartext traffic (on older APIs), which could expose sensitive data like cached Reddit OAuth tokens through physical device backups or MITM network attacks.π― Impact: An attacker with physical access could use
adb backupto extract OAuth tokens and browse data. Without enforced HTTPS, network traffic might be intercepted on older APIs.π§ Fix: Explicitly set
android:allowBackup="false"andandroid:usesCleartextTraffic="false"inAndroidManifest.xml. Also resolved a compiler conflict withandroidx.compose.ui.semantics.RoleinMinimalButton.ktand an API level lint error inthemes.xml.β Verification: Ran
./gradlew testand./gradlew lintsuccessfully.PR created automatically by Jules for task 6680996972366352926 started by @LeanBitLab