Skip to content

🎨 Palette: Improve screen reader a11y for custom buttons - #14

Open
LeanBitLab wants to merge 1 commit into
mainfrom
palette/a11y-compose-buttons-6178877680850775327
Open

LeanBitLab wants to merge 1 commit into
mainfrom
palette/a11y-compose-buttons-6178877680850775327

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

💡 What: Added explicit Role.Button semantic roles to custom clickable Compose components in VideoPage.kt, and removed a redundant contentDescription on the expand icon.
🎯 Why: Screen readers would previously read custom buttons simply as text or generic clickable zones. The expand icon also duplicated the "Show more"/"Show less" text right next to it, making navigation tedious.
📸 Before/After: N/A (Visual UI remains unchanged)
♿ Accessibility: Ensures correct interactive component announcements by TalkBack/VoiceOver and removes confusing redundant announcements.


PR created automatically by Jules for task 6178877680850775327 started by @LeanBitLab

- Add `role = Role.Button` to `Modifier.clickable` across custom UI buttons in `VideoPage.kt` to ensure screen readers identify them as interactive elements.
- Set `contentDescription = null` for the ExpandLess/ExpandMore icon where it sits next to descriptive text, avoiding duplicate screen reader announcements.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant