Skip to content

🎨 Palette: [UX improvement] Improve VideoPage accessibility #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeanBitLab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: [UX improvement] Improve VideoPage accessibility #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
## 2024-05-18 - Redundant Icon Content Descriptions
**Learning:** Adding `contentDescription` to icons that are directly adjacent to `Text` components containing the same wording is an anti-pattern. Screen readers will announce the information twice (e.g., "Liked, Liked"), creating a noisy experience. Icons in this context should remain decorative (`contentDescription = null`).
**Action:** Verify if text alternatives exist near visual elements before assigning a `contentDescription` to avoid duplicate screen reader announcements.
## $(date +%Y-%m-%d) - Dynamic Content Descriptions
**Learning:** State-dependent buttons (like Mute/Unmute or Lock/Unlock) need dynamic `contentDescription`s to accurately reflect the action they perform when toggled, rather than statically describing the button's purpose. Screen readers use this context to clarify the action to the user.
**Action:** When working with toggleable state buttons, update `contentDescription` to be dynamic (e.g., `if (isMuted) "Unmute" else "Mute"`) instead of using a static string.
17 changes: 9 additions & 8 deletions app/src/main/java/com/example/reddittube/ui/main/VideoPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ import androidx.compose.ui.platform.LocalHapticFeedback
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.customActions
import androidx.compose.ui.semantics.CustomAccessibilityAction
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
Expand Down Expand Up @@ -729,7 +730,7 @@ Box(
.clip(CircleShape)
.background(Color.Black.copy(alpha = 0.65f))
.border(1.dp, GlassBorder, CircleShape)
.clickable {
.clickable(role = Role.Button) {
hapticFeedback.performHapticFeedback(HapticFeedbackType.LongPress)
if (exoPlayer.playbackState == Player.STATE_ENDED) {
exoPlayer.seekTo(0)
Expand Down Expand Up @@ -786,7 +787,7 @@ Box(
.size(40.dp)
.clip(CircleShape)
.background(Color.Black.copy(alpha = 0.55f))
.clickable { onBack?.invoke() },
.clickable(role = Role.Button) { onBack?.invoke() },
contentAlignment = Alignment.Center
) {
Icon(Icons.Default.ArrowBack, contentDescription = "Back", tint = Color.White, modifier = Modifier.size(22.dp))
Expand Down Expand Up @@ -868,7 +869,7 @@ Box(
color = BrandRed,
fontSize = 16.sp,
fontWeight = FontWeight.Bold,
modifier = Modifier.clickable { onSubredditClick(post.subreddit) }
modifier = Modifier.clickable(role = Role.Button) { onSubredditClick(post.subreddit) }
)
Spacer(modifier = Modifier.width(6.dp))
val isSubbed = subscribedSet.contains(post.subreddit.lowercase())
Expand All @@ -877,7 +878,7 @@ Box(
.size(32.dp)
.clip(CircleShape)
.background(BrandRed.copy(alpha = if (isSubbed) 0.2f else 0.15f))
.clickable {
.clickable(role = Role.Button) {
hapticFeedback.performHapticFeedback(HapticFeedbackType.LongPress)
onSubscribeToggle(post.subreddit.lowercase())
},
Expand Down Expand Up @@ -988,7 +989,7 @@ Box(
) {
Icon(
if (isRotationLocked) Icons.Default.Lock else Icons.Default.LockOpen,
contentDescription = "Rotation",
contentDescription = if (isRotationLocked) "Unlock rotation" else "Lock rotation",
tint = if (isRotationLocked) BrandRed else Color.White,
modifier = Modifier.size(14.dp)
)
Expand All @@ -1001,7 +1002,7 @@ Box(
) {
Icon(
if (isMuted) Icons.AutoMirrored.Filled.VolumeOff else Icons.AutoMirrored.Filled.VolumeUp,
contentDescription = "Mute",
contentDescription = if (isMuted) "Unmute" else "Mute",
tint = if (isMuted) BrandRed else Color.White,
modifier = Modifier.size(14.dp)
)
Expand All @@ -1017,7 +1018,7 @@ Box(
) {
Icon(
Icons.Default.SkipNext,
contentDescription = "Auto-next",
contentDescription = if (autoNextEnabled) "Disable auto-next" else "Enable auto-next",
tint = if (autoNextEnabled) Color.White else TextMuted,
modifier = Modifier.size(14.dp)
)
Expand All @@ -1034,7 +1035,7 @@ Box(
) {
Icon(
Icons.Default.Repeat,
contentDescription = "Loop video",
contentDescription = if (isLoopEnabled) "Disable loop" else "Enable loop",
tint = if (isLoopEnabled) Color.White else TextMuted,
modifier = Modifier.size(14.dp)
)
Expand Down
1 change: 0 additions & 1 deletion app/src/main/java/com/example/reddittube/ui/main/components/MinimalButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp

Expand Down
Loading