Repository navigation
🎨 Palette: [UX improvement] - Enhance screen reader accessibility on VideoPage buttons - #3
LeanBitLab wants to merge 1 commit into
Conversation
Added `role = Role.Button` to `MinimalButton.kt`'s `.clickable` modifier to ensure screen readers announce it as a button. Updated stateful toggle buttons (Lock, Mute, Auto-next, Loop) in `VideoPage.kt` to use dynamic `contentDescription`s (e.g. "Unmute" vs "Mute") reflecting the action to be taken.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role = Role.Buttonto the customMinimalButtoncomponent and updated the stateful toggle buttons on the Video Player screen (Rotation Lock, Mute, Auto-next, Loop) to use dynamiccontentDescriptionstrings reflecting their next state (e.g., "Unmute" instead of just "Mute").🎯 Why: Screen readers need to know that custom clickable elements are buttons. Furthermore, static descriptions on toggle buttons confuse users; the description should tell the user what will happen when they click it.
📸 Before/After: Visuals remain unchanged. Screen readers will now announce "Button, Unmute" instead of "Mute".
♿ Accessibility: Major improvement for screen reader users by providing accurate context and semantics for critical video controls.
PR created automatically by Jules for task 13206756953252060737 started by @LeanBitLab