chore(providers/aws): periodic audit of findOfferingID across 7 services (closes #515)#815
chore(providers/aws): periodic audit of findOfferingID across 7 services (closes #515)#815cristim wants to merge 1 commit into
Conversation
cristim
added
triaged
|
@coderabbitai review |
|
Warning Review limit reached
More reviews will be available in 1 minute and 45 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai review |
Rate Limit Exceeded
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
All 7 service clients (EC2, RDS, ElastiCache, MemoryDB, OpenSearch, Redshift, SavingsPlans) pass the 6-item contract from PR #690: typed fields, ctx.Err() at loop top, page cap, per-page log, variant skip, nil+empty token terminator. Fix three pre-existing test build failures: missing execID argument in RDS/Redshift/SavingsPlans findOfferingID test call sites. Add TestFindOfferingID_CtxCancelledBeforePage and TestFindOfferingID_EmptyStringTokenEndsPagination to every service's client_test.go (14 new tests) to pin contract items C2 and C6. Add providers/aws/services/AUDIT.md with the 6-item contract, per-service status table, watchlist items (MemoryDB Valkey engine split, OpenSearch and Redshift Graviton dimension), and quarterly audit procedure.
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Summary
findOfferingID(EC2, RDS, ElastiCache, MemoryDB, OpenSearch, Redshift, SavingsPlans) against the contract established in PR fix(purchases): narrow Describe*Offerings + cap pagination (#688) #690: typed fields, ctx.Err() check, page cap, per-page log, variant soft-skip, nil+empty token terminator.execIDarg in RDS, Redshift, SavingsPlans test calls) are fixed.providers/aws/services/AUDIT.mddocuments the 6-item contract, per-service status table, watchlist (MemoryDB Valkey engine split, OpenSearch/Redshift Graviton dimension), and quarterly audit procedure.TestFindOfferingID_CtxCancelledBeforePageandTestFindOfferingID_EmptyStringTokenEndsPaginationto every service's test file (14 new tests across 7 packages) to pin contract items C2 and C6 against future regressions.Test plan
go test ./providers/aws/services/...-- 319 tests pass across all 7 packagesgo build ./...-- cleanproviders/aws/services/AUDIT.mdfor completeness and accuracy