Skip to content

chore(gitignore): ignore the default purchase audit log - #2260

Merged
cristim merged 1 commit into
mainfrom
chore/gitignore-audit-log
Oct 17, 2026
Merged

cristim merged 1 commit into
mainfrom
chore/gitignore-audit-log

Conversation

@cristim

@cristim cristim commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Refs #1162

Summary

On 2026-10-17 the owner decided to leave the local customer-data files where they are and to make sure they are gitignored. *.csv reports were already ignored (.gitignore:2). The purchase audit log was not: its default path is ./cudly-audit.jsonl (cmd/main.go:149), and it holds account IDs and purchase records. A run from the repo root therefore left a sensitive file untracked, where it could be committed by accident.

This PR adds cudly-audit*.jsonl to .gitignore. The pattern is unanchored because a run from cmd/ writes the file there too.

Evidence

  • git check-ignore -v matches both cudly-audit.jsonl and cmd/cudly-audit.jsonl.
  • git ls-files -ci --exclude-standard is empty, so no tracked file becomes ignored, and no .jsonl file is tracked.
  • An independent non-author reviewer (sonnet, high) checked two passes and found no actionable findings:
    • No other default output path holds customer data unignored.
    • Tests write their audit logs under t.TempDir().
    • The prefix pattern is preferable to a bare *.jsonl, which would also hide future committed fixtures.

🤖 Generated with Claude Code

The default --audit-log path is ./cudly-audit.jsonl. The log holds
account IDs and purchase records, but unlike the *.csv reports it was not
ignored, so a run from the repo root left it untracked and committable.
Ignore cudly-audit*.jsonl anywhere in the tree (runs from cmd/ write it
there too). Per the owner decision on #1162 the existing local files stay
where they are.

Closes #1162

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim cristim added priority/p3 Polish / idea / may never ship severity/medium Moderate harm urgency/eventually No deadline impact/internal Team-internal only effort/s Hours type/security Security finding triaged Item has been triaged labels Oct 17, 2026
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 21 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 75 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 09b8b065-4b2e-416d-b055-1b5b2ecfb782
📥 Commits

Reviewing files that changed from the base of the PR and between 0f7b9b6 and 8870074.

📒 Files selected for processing: 1
  • .gitignore
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

Independent review verdict: CLEAN at 8870074

Reviewer: fresh Claude agent (Sonnet 5.5, high effort), not the author, with a cold brief. Coordinator: claude-cc-reviewer.

What was checked

  • The default audit log is "./cudly-audit.jsonl" (cmd/main.go:149). The new pattern cudly-audit*.jsonl (.gitignore:4) matches it.
  • git check-ignore -v in a scratch repo ignores cudly-audit.jsonl and x/cudly-audit.jsonl. It does not ignore unrelated .jsonl files.
  • No tracked file matches the pattern, so nothing that is needed gets hidden.

Scope
#1162 is mostly about real account data in CSVs. Its recommendations are to move the CSVs, change the default output dir, and add a git-secrets pattern. This PR covers only the audit-log part, so I changed the body from Closes #1162 to Refs #1162 to keep the issue open for the rest. The labels are still mirrored from #1162.

Local verification
This is a non-runtime change. I ran the ignore-pattern checks listed above.

Gate

  • CodeRabbit is rate limited. It is optional here, because exact-revision verification plus this review cover the SHA.
  • Merge once CI is green.

@cristim
cristim merged commit 1cf7258 into main Oct 17, 2026
12 checks passed
@cristim
cristim deleted the chore/gitignore-audit-log branch October 17, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/medium Moderate harm triaged Item has been triaged type/security Security finding urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant