Skip to content

chore(azure): remove dead OnDemandPrice and SavingsPercentage fields from pricing structs #198

Closed
#532
Closed
chore(azure): remove dead OnDemandPrice and SavingsPercentage fields from pricing structs#198
#532
Labels
effort/sHoursimpact/internalTeam-internal onlypriority/p3Polish / idea / may never shipseverity/lowMinor harmstatus/blockedBlocked on something externaltriagedItem has been triagedtype/choreMaintenance / non-user-visibleurgency/eventuallyNo deadline

Description

@cristim
cristim
opened on Oct 5, 2026

After PR #178, VMPricing.OnDemandPrice and SavingsPercentage (providers/azure/services/compute/client.go:691-693) are dead. The Redis and Cosmos pricing structs carry the same dead fields.

Acceptance: fields removed from the VM, Redis and Cosmos pricing structs, plus any assignments and test references; build and tests pass.

Activity

  1. cristim
    added
    triagedItem has been triaged
    impact/internalTeam-internal only
    type/choreMaintenance / non-user-visible
    priority/p3Polish / idea / may never ship
    severity/lowMinor harm
    urgency/eventuallyNo deadline
    effort/sHours
    on Oct 5, 2026

  2. cristim commented on Oct 17, 2026

    @cristim
    cristim
    on Oct 17, 2026
    MemberAuthor

    Checked against main: still valid. OnDemandPrice and SavingsPercentage are dead in five Azure structs (compute, cache, cosmosdb, database, managedredis client.go), all edited by open PR #473. Blocked on #473.

  3. cristim
    added
    status/blockedBlocked on something external
    on Oct 17, 2026

  4. cristim commented on Oct 19, 2026

    @cristim
    cristim
    on Oct 19, 2026
    MemberAuthor

    Claiming: remove the dead OnDemandPrice/SavingsPercentage pricing-struct fields [claude-cc-libs]

  5. cristim
    closed this as completedin #532on Oct 19, 2026
  6. IAmJSD
    added a commit that references this issue on Oct 20, 2026

    chore(azure): remove dead OnDemandPrice and SavingsPercentage pricing…

    2a4ec8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort/sHoursimpact/internalTeam-internal onlypriority/p3Polish / idea / may never shipseverity/lowMinor harmstatus/blockedBlocked on something externaltriagedItem has been triagedtype/choreMaintenance / non-user-visibleurgency/eventuallyNo deadline

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions