Skip to content

docs(ladder): document provider commitment precision at PurchaseLayer #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 4 commits into from
Oct 16, 2026
Merged

docs(ladder): document provider commitment precision at PurchaseLayer #438

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afc6f3e
docs(ladder): document provider commitment precision at PurchaseLayer
IAmJSD Oct 16, 2026
47d8440
docs(ladder): order the AWS range check before truncation; note conve…
IAmJSD Oct 16, 2026
6fb60f9
Merge origin/main (picks up the offline golangci config verify, #420)
IAmJSD Oct 16, 2026
732f172
Merge origin/main to bring the branch up to date
IAmJSD Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/ladder/capability.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,19 @@ type LadderCapability interface {
// the float64 cost fields of common.Recommendation. This is a documented
// precision seam; exact-decimal plumbing through the purchase path is
// addressed in a later PR.
//
// Provider commitment precision (go#354): implementations MUST floor the
// commitment to the provider's precision before submission, never round
// it up, and MUST refuse (not submit) an amount outside the provider's
// accepted range, including one that floors to zero. Callers converting
// a *big.Rat amount to float64 must not round it up either.
// - AWS Savings Plans: the raw amount is range-checked first (outside
// [0.001, 1000000] USD/hr, NaN, Inf or <= 0 is refused before any
// API call), then truncated to 5 decimal places.
// - AWS convertible RIs: purchased as a whole instance count
// (rec.Count > 0), so there is no dollar amount to floor.
// - Azure, GCP: no LadderCapability implementation yet; each must
// document and enforce its precision here when one is added.
PurchaseLayer(ctx context.Context, layer LayerType, rec common.Recommendation, opts common.PurchaseOptions) (common.PurchaseResult, error)

// ReshapeBuffer exchanges or modifies buffer-layer commitments to improve
Expand Down
Loading