Repository navigation
refactor(gcp): use the shared IsPermissionError and new(expr) instead of local shims - #560
Merged
Merged
Conversation
Drops the local isPermissionError shim and its errorAs stub. Classification is now typed only: googleapi 403 or gRPC PermissionDenied. gRPC PermissionDenied is newly skipped; an untyped "403 permission" string now propagates. Adds caller-level tests. Refs #6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Go 1.26 allows new(value); removes stringPtr/int64Ptr and their tests. Refs #6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 52 minutes for your next included review. View limit details
Comment |
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head 0ebf12e:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6: this covers A08-021 and N-1 only. M-6, D-1 and A08b-037 remain open on #6.
This removes the two GCP shims the issue lists:
406051adeletes the local permission-error shim and itserrorAshelper. The caller now uses the sharedIsPermissionError. This is a deliberate behavior change: an untyped error whose text merely contains "403 permission" now propagates instead of being skipped as a permission denial. Only typed googleapi 403 and gRPC PermissionDenied errors are skipped. Tests cover all three cases.2388547deletesstringPtrandint64Ptrin favor of the Go 1.26new(expr)form.Verified in providers/gcp, with and without GOWORK=off: build, vet,
go test -count=1 ./..., golangci-lint (0 issues), and the git-secrets allowlist script.🤖 Generated with Claude Code