Repository navigation
chore(lint): reorder providers/gcp structs and re-enable fieldalignment - #596
Conversation
Remove fieldalignment from govet.disable now that pkg and every provider module pass. Findings in _test.go files are excluded by message text, so other govet checks still run in tests; test-table layout is irrelevant and reordering positional table literals risks silent misassignment. Mirrors cloud-commitments-cli#2262. Closes #100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 9 billable files and costs up to $2.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 51 minutes for your next included review. View limit details
Comment |
…r in providers/gcp Rebuild each reordered struct body so every field keeps its own doc comment directly above it and group headers head only the fields they describe (repeated per contiguous run where the layout splits a group). Documented fields are blank-line separated so no undocumented field sits under another field comment. Part of #100 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gate note (claude-cc-libs)Head 5703c8b is the reviewed e9e4556 plus main (after #589 and #606). Excluding CHANGELOG.md, the added and removed lines are identical to the reviewed diff. Only .golangci.yml context lines differ, because #606 pruned neighbouring exclusions on main. Both reviewers simulated main + #589 + #596 with 0 lint issues in all 5 modules. |
Merge gate verdict (claude-cc-libs)Every gate holds at head 5703c8b:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
Closes #100. Last of four per-module PRs (pkg #589, providers/aws #590, providers/azure #593, providers/gcp). Merge this one last: it removes
fieldalignmentfromgovet.disable, so CI lint on the other modules only passes once their PRs are in.Changes
providers/gcpstruct fields to the fieldalignment-optimal layout (15 findings).//nolint:govet // fieldalignment: file owned by open PR #471onClient,SQLPricing,StoragePricingandRedisPricinginservices/{cloudsql,cloudstorage,memorystore}/client.go..golangci.yml: dropfieldalignmentfromgovet.disable; excludefieldalignment:findings in_test.go(matched by message, so other govet checks still run in tests), mirroring cloud-commitments-cli#2262. Test-table layout is irrelevant and reordering positional table literals risks silent misassignment.Checks
unsafe.Sizeoforbinary.Read/Writeon these structs; cli, mcp and platform at origin/main have no unkeyed composite literals of module structs (AST scan).go build,go vet,go test -timeout 300s -count=1 ./...and golangci-lint with the new config pass inproviders/gcpandci_cd_sanity_tests, with and withoutGOWORK=off;pkg, aws and azure pass with the same config once their PRs land.🤖 Generated with Claude Code