Repository navigation
Conversation
…se path Replace the OpenSearch-local copy of the issue #641 idempotency guard and AlreadyExists recovery with purchaseguard.Guard and Recover, as ElastiCache already does (#507). The lookup and fault type stay service-specific. Add purchase_guard_test.go covering each guard rule at this path: no lookup without a token, lookup before purchase, fail-loud lookup error, and AlreadyExists recovery limits (re-lookup error or miss, no token, other purchase errors). Mocks are bounded with Test(t). Part of #10 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 40 minutes for your next included review. View limit details
Comment |
Member
Author
|
Closing: accidental duplicate of #597 (two push runs raced). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purchaseguard.Guardandpurchaseguard.Recoverinstead of its own copy of the issue #641 guard, mirroring ElastiCache (refactor(aws): share the purchase idempotency guard, starting with ElastiCache #507,providers/aws/services/elasticache/client.goidempotencyGuardandrecoverAlreadyExists).purchase_guard_test.gocovers each guard rule at this path with bounded mocks.Verification
go test -timeout 300s -count=1 ./..., golangci-lint (0 issues) and the git-secrets script, with and without GOWORK=off.Closes #10 (ElastiCache, RDS and MemoryDB landed in the sibling PRs)
🤖 Generated with Claude Code