Repository navigation
chore(pre-commit): set default_install_hook_types so install arms both stages - #63
Merged
Merged
Conversation
…h stages default_stages already lists pre-push, but without default_install_hook_types a plain `pre-commit install` wires only the pre-commit git hook, so the pre-push go-test stage silently never ran locally. Verified in a scratch repo: the old config installs only pre-commit, the new one installs pre-commit and pre-push. Closes #10 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merge-driver verdict: CLEAN at An independent adversarial reviewer (Sonnet, high effort, cold brief, not the author) reviewed the full diff. It found no blocking findings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pre-commit-config.yamllistedpre-pushindefault_stagesbut did not setdefault_install_hook_types. As a result, a plainpre-commit installwired only the pre-commit git hook, and the pre-push go-test stage never ran locally. This PR addsdefault_install_hook_types: [pre-commit, pre-push]and updates the go-test block's comment, which still told devs to pass--hook-type pre-pushby hand.Closes #10
Verification (local, macOS, at a4c7de3)
pre-commit validate-config .pre-commit-config.yamlpasses (pre-commit 4.7.0).pre-commit install:.git/hookscontains onlypre-commit.pre-commitandpre-push.pre-commit run --all-files, which uses the default pre-commit stage; the new setting only affectsinstall.git push.Review
A non-author reviewer (Sonnet, high effort) did two passes on the diff and reproduced the install behaviour. No actionable findings. Its one nit, the stale
--hook-type pre-pushcomment, is fixed in this PR. The final gate belongs to the merge driver.🤖 Generated with Claude Code
Summary by CodeRabbit
pre-commit installenables both pre-commit and pre-push checks, including Go tests and frontend builds and tests.