Repository navigation
chore(gitignore): ignore root reports written by Makefile targets - #64
Conversation
make test-coverage, security-scan-go and complexity-report write coverage.html, gosec-report.json and complexity-report.txt at the repo root, and none was ignored, so they showed up as untracked and could be committed by accident. The patterns are anchored to the root so same-named files elsewhere stay visible. They match the list make clean removes. Closes #11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 53 minutes for your next included review. View limit details
Comment |
|
Correction to the verification section (body updated): the earlier exit 2 from |
|
Merge-driver verdict: CLEAN at An independent adversarial reviewer (Sonnet, high effort, cold brief, not the author) reviewed the full diff. It found no blocking findings.
|
Summary
Three Makefile targets write reports at the repo root, and none of these files was ignored, so each showed up as untracked and could be committed by accident:
make test-coveragewritescoverage.html.make security-scan-gowritesgosec-report.json.make complexity-reportwritescomplexity-report.txt.This PR adds root-anchored patterns for all three. They match the list
make cleanremoves (Makefile:59);coverage.outwas already covered by*.out.Closes #11
Verification (local, macOS, at 55d138a)
git check-ignorematches none of the three files (exit 1).make complexity-report,make security-scan-goandmake test-coveragein the worktree.git check-ignore -vattributes each output to .gitignore:34-36, andgit status --untracked-files=allshows only the .gitignore edit.make security-scan-gofirst exited 2 under the machine default Go 1.27: the pinned gosec binary, built with Go 1.26, could not read Go 1.27 export data. That is a setup failure, not findings. Re-run withGOTOOLCHAIN=go1.26.9(go.mod), it exits 0 with no findings and writesgosec-report.json, which is ignored.tools/x/coverage.htmlstays unignored.git ls-files -i -c --exclude-standardis empty, so no tracked file matches the new patterns.Review
A non-author reviewer (Sonnet, high effort) did two passes and reproduced the check-ignore results. It searched the Makefile, scripts/, workflows and .goreleaser.yml for other root artifacts and found none. No actionable findings. CodeRabbit is not pinged because the org's CR quota is exhausted.
🤖 Generated with Claude Code