Skip to content

docs(claude): replace the remaining em-dashes in CLAUDE.md - #71

Merged
cristim merged 1 commit into
mainfrom
docs/17-claude-md-em-dashes
Oct 17, 2026
Merged

cristim merged 1 commit into
mainfrom
docs/17-claude-md-em-dashes

Conversation

@cristim

@cristim cristim commented Oct 16, 2026

Copy link
Copy Markdown
Member

Summary

The project prose rule bans em-dashes (U+2014). This repo's CLAUDE.md still had 12; the issue's 2026-09-27 count was 24, and some were removed by later edits. Each one is now a colon, semicolon, comma or sentence break, chosen for its sentence. The wording and force of every rule are unchanged; for example, "MANDATORY" and "Do NOT skip this step; it is mandatory" stay requirements.

Three headings change, and so do their anchor slugs. Nothing in the repo links to them: there are no ](# links in CLAUDE.md and no CLAUDE.md# references elsewhere.

Closes #17

Verification (at 1f20869)

  • python3 -c "print(open('CLAUDE.md',encoding='utf-8').read().count(chr(0x2014)))" prints 0; origin/main gives 12.
  • git diff --word-diff shows only the 12 dash sites changed (1 file, 12 lines).
  • markdownlint-cli2 CLAUDE.md reports 0 issues.

Review

A non-author reviewer (Sonnet, high effort) did two passes. It checked that each replacement keeps the rule's meaning and force, and that the anchors are unused. No actionable findings.

Outside this issue's scope, em-dashes remain in comments in .pre-commit-config.yaml, .github/workflows/pre-commit.yml and .gitignore, plus one echo string in pre-commit.yml. CodeRabbit is not pinged because the org's CR quota is exhausted.

🤖 Generated with Claude Code

The project rule bans em-dashes in prose, and CLAUDE.md still had 12.
Each becomes a colon, semicolon, comma or sentence break chosen for
its sentence; rule wording and force are unchanged. Three headings
change slug; nothing links to them.

Closes #17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim cristim added impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline effort/s Hours type/docs Documentation triaged Item has been triaged labels Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 59 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c494b90d-1b71-404f-b0ca-5e1fb5f8380f
📥 Commits

Reviewing files that changed from the base of the PR and between 02ea149 and 1f20869.

📒 Files selected for processing: 1
  • CLAUDE.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

CI note: Lint Code failed in run 38836492087 because golangci-lint config verify timed out downloading its JSON schema from golangci-lint.run; all other jobs were green. That is unrelated to this CLAUDE.md-only diff, so I re-ran the failed job; the root cause is tracked in #72. [claude-mcp-impl]

@cristim

cristim commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

Merge-driver verdict: CLEAN at 1f208695fba9e8495663c368b5e5e66a726515d2

An independent adversarial reviewer (Sonnet, high effort, cold brief, not the author) reviewed the full diff. It found no blocking findings.

Local verification (real, on the actual files):

  • Em-dash count: U+2014 in CLAUDE.md goes from 12 on main to 0. (HYG: Replace 24 pre-existing em-dashes in CLAUDE.md (project rule) [mcp part] #17's title says 24, but main had 12 left.)
  • Scope: the word-diff shows that only the 12 dash sites changed. Each dash became ;, :, , or ., and no command text changed.
  • Headings: three headings were renamed. A repo-wide grep finds no anchor references to them.
  • Meaning: every rule reads the same after the edit.

Gate items:

@cristim

cristim commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

Gate record for head 1f208695fba9e8495663c368b5e5e66a726515d2: CR waived: quota, adversarial review + local verification + green CI. The verdict and evidence are in the merge-driver comment above. This comment also requests a retrospective CodeRabbit pass; any actionable findings it raises will be resolved.

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

Automated review of 1f20869: no blocking findings and CI is green. Ready to merge.
Docs-only PR replacing em-dashes with colons or semicolons in CLAUDE.md. Each edit reads correctly and changes no meaning. No em-dashes remain in the file. No code, security, or test impact.

Posted by a read-only review sweep. It stays silent on this commit and re-reviews only after a new push.

@cristim
cristim merged commit 8569f85 into main Oct 17, 2026
20 of 22 checks passed
@cristim
cristim deleted the docs/17-claude-md-em-dashes branch October 17, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/docs Documentation urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HYG: Replace 24 pre-existing em-dashes in CLAUDE.md (project rule) [mcp part]

1 participant