Skip to content

fix(history): keep the lineage link on failed rows that show an ops hint #1040

Open

Description

@cristim

Problem

In frontend/src/history.ts, renderActionCell returns early for a failed row that carries an ops_hint, so the row never renders its lineage link ("↻ Retried as #…" / "↻ Retry #N"). An operator looking at such a row loses the direct link to its successor.

This early return predates #967 (it came with the ops-hint badge in #47). #967 widened the set of rows that carry a hint to executions the backend will never re-drive (redrive_unsafe). The visible case is a legacy row that was retried before the re-drive gate existed: it now shows the permanent hint and no longer links to its successor.

Found by CodeRabbit on #967 (thread on internal/api/handler_history.go:406).

Expected

A failed row with an ops_hint renders the hint badge and, when present, the lineage links in the same cell. Retry stays hidden.

Suggested fix

In the ops-hint branch, compose the badge with the lineage array instead of returning the badge alone. Add a jest case: failed row with ops_hint and retry_execution_id renders both the hint and the "Retried as" link, and no Retry button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions