Skip to content

test(frontend): assert every #plan-service optgroup in index.html carries a valid data-provider #413

Closed

Description

@cristim

Follow-up from the review of #407 (closes #241). updateServiceDropdownForProvider now keys on optgroup.dataset.provider, so an optgroup added to #plan-service without data-provider is silently hidden for every provider. The plans.test.ts tests use an inline fixture and never load the real markup.

Add a jest test that parses frontend/src/index.html and asserts every #plan-service > optgroup has data-provider in {aws, azure, gcp}. That covers the real markup and catches the regression.

Activity

  1. added
    type/choreMaintenance / non-user-visible
    priority/p3Polish / idea / may never ship
    effort/xsTrivial / one-liner
    on Sep 28, 2026
  2. IAmJSD commented on Oct 24, 2026

    @IAmJSD
    Collaborator

    Closing as covered by #1067 (c632bc1). frontend/src/__tests__/plan-service-ids.test.ts ('canonical set equals the #plan-service options in index.html per provider') parses the real index.html and keys every #plan-service > optgroup by data-provider. A missing, mis-cased or unknown provider fails the toEqual(CANONICAL_PLAN_SERVICES) assertion. We checked this against main a14dc8f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions