Skip to content

ci: keep gocyclo's filesystem walk out of node_modules and vendor #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IAmJSD wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Draft

ci: keep gocyclo's filesystem walk out of node_modules and vendor #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ jobs:
# Exclude _test.go files to stay consistent with .golangci.yml, which
# excludes gocyclo on test files (test helpers/table-driven tests are
# allowed higher complexity). Production code is still gated at >10.
COMPLEXITY_ISSUES=$(gocyclo -over 10 -ignore "_test\.go" . 2>&1 || true)
# Also exclude node_modules/ and vendor/ trees: the `.` walk would
# otherwise report third-party Go files that npm packages ship
# (e.g. frontend/node_modules/flatted) whenever deps are installed.
COMPLEXITY_ISSUES=$(gocyclo -over 10 -ignore "_test\.go|(^|/)(node_modules|vendor)/" . 2>&1 || true)
if [ -n "$COMPLEXITY_ISSUES" ]; then
echo "❌ Found functions with cyclomatic complexity over 10:"
echo "$COMPLEXITY_ISSUES"
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ vet:
complexity:
@echo "Checking cyclomatic complexity (threshold: 10)..."
@if command -v gocyclo > /dev/null; then \
COMPLEXITY_ISSUES=$$(gocyclo -over 10 . 2>&1 || true); \
COMPLEXITY_ISSUES=$$(gocyclo -over 10 -ignore '(^|/)(node_modules|vendor)/' . 2>&1 || true); \
if [ -n "$$COMPLEXITY_ISSUES" ]; then \
echo "❌ Found functions with cyclomatic complexity over 10:"; \
echo "$$COMPLEXITY_ISSUES"; \
Expand All @@ -149,7 +149,7 @@ complexity:
complexity-report:
@echo "Generating cyclomatic complexity report..."
@if command -v gocyclo > /dev/null; then \
gocyclo -top 20 . | tee complexity-report.txt; \
gocyclo -top 20 -ignore '(^|/)(node_modules|vendor)/' . | tee complexity-report.txt; \
echo ""; \
echo "📊 Top 20 most complex functions saved to: complexity-report.txt"; \
else \
Expand Down
Loading