Repository navigation
Take the DANDI API key in the GUI - #567
Closed
pauladkisson wants to merge 2 commits into
Closed
pauladkisson wants to merge 2 commits into
pauladkisson wants to merge 2 commits into
Conversation
The DANDI panel gets a DANDI API key field; a pasted key is used for the rest of the GuPPy session and is not saved. Before streaming, GuPPy checks for a key in DANDI_API_KEY or the keyring and raises a ValueError naming the field when there is none, so the dandi library never falls back to its terminal prompt. Label Stores now surfaces such errors as a notification. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pauladkisson
marked this pull request as ready for review
October 15, 2026 21:54
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Superseded by #568. Public dandisets stream without a key, so GuPPy no longer asks for one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details (AI-generated)
Closes #566.
DANDI_API_KEYfor the GuPPy process, so it applies to the rest of the session, and it is never written to disk._stream_nwbcalls the newrequire_dandi_api_key()(utils/dandi_auth.py), which looks for a key inDANDI_API_KEYand then the keyringdandi loginwrites to, the same placesdandichecks. Without one it raises aValueErrornaming the field, sodandinever reaches itsinput()prompt.ValueErrorand shows a notification, as the other page-opening handlers already do. Step 2 already reports worker errors this way.dandi loginor the environment variable as ways to skip pasting the key on each launch.Searching, listing and previewing don't authenticate, so they still work without a key. I confirmed that a keyring lookup inside the container image from #560 returns nothing without prompting.
test_dandi_auth,test_dandi_file_panel,test_home,test_store_labelingandtest_dandi_nwb_recording_extractorpass. In Playwright the field renders as a masked input above the DANDI search. I didn't run a full stream with a real key.🤖 Generated with Claude Code