fix(schedule): allow explicit label visibility bypass#1475
Open
JohnVillalovos wants to merge 1 commit into
Open
fix(schedule): allow explicit label visibility bypass#1475JohnVillalovos wants to merge 1 commit into
JohnVillalovos wants to merge 1 commit into
Conversation
Add an explicit skipVisibilityChecks argument to SlotLabelFactory::Format for callers that have already authorized reservation details. Keep the default path unchanged and keep NullSlotLabelFactory fail-closed. Co-Authored-By: John L. Villalovos <john@sodarock.com> Assisted-by: Codex:GPT-5
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the schedule label formatting API by adding an explicit skipVisibilityChecks argument to SlotLabelFactory::Format() for trusted callers that have already authorized access to reservation details (e.g., authenticated subscription feeds). The default behavior remains unchanged, and NullSlotLabelFactory continues to return an empty label.
Changes:
- Add
skipVisibilityChecks(defaultfalse) toSlotLabelFactory::Format()and toNullSlotLabelFactory::Format(). - Keep user-detail redaction enforced when
privacy.hide.user.detailsis enabled (now applies to{email},{phone},{organization},{position},{participants},{invitees}as well). - Add PHPUnit coverage ensuring the bypass works when explicitly requested, while still redacting user tokens and keeping
NullSlotLabelFactoryfail-closed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/Application/Schedule/SlotLabelFactory.php |
Adds the skipVisibilityChecks parameter and ensures user-detail redaction is consistently applied across all user-related tokens. |
tests/Presenters/CalendarExportPresenterTest.php |
Adds tests validating explicit visibility bypass behavior and fail-closed behavior for NullSlotLabelFactory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit skipVisibilityChecks argument to
SlotLabelFactory::Format for callers that have already authorized reservation details. Keep the default path unchanged and keep NullSlotLabelFactory fail-closed.
Assisted-by: Codex:GPT-5