Skip to content

Adding PSR-4 support#1552

Open
barakiva wants to merge 7 commits into
LibreBooking:developfrom
barakiva:psr-4
Open

Adding PSR-4 support#1552
barakiva wants to merge 7 commits into
LibreBooking:developfrom
barakiva:psr-4

Conversation

@barakiva

Copy link
Copy Markdown
Contributor

Addressing #1501 , this PR adds PSR-4 to the project. I've went in greater depth with regards to the necessity of PSR-4 in the issue. But in general, PSR-4 gives us the following:

  1. Sane imports. even the strict require_once still silently executes files, introducing many code smells like polluting the global namespace
  2. Better performance as imports are explicit. Even with smart compiler tree shaking, using barel files such as namespace.php with dozen of files fires off unecessary system calls in the file lookups.
  3. Stricter allows us to reveal expensive runtime errors in compile time using static analysis.

barakiva added 7 commits July 14, 2026 16:01
…ng of azure's 'error' whereas before failures would be silent.

Assisted-By:claude-code-sonnet-4.6

"~/Development/Projects/Bookme/librebooking/.git/COMMIT_EDITMSG" 25L, 1262B                                         1,1           Top
test(auth): refactor microsoft-auth to make it testable. Added handling of azure's 'error' whereas before failures would be silent.

Assisted-By:claude-code-sonnet-4.6

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is seeming to undo recent commits. Please fix that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants