-
Notifications
You must be signed in to change notification settings - Fork 55
馃彄 feat: Dispatch Worker-Local Workspace Tools #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0aaddf7
feat(code): dispatch local workspace tools
danny-avila bc0d263
fix(code): fence workspace tool completion
danny-avila eff619e
fix(code): drain workspace cancellation before settlement
danny-avila 6be38d2
fix(code): drain active cancellation responses
danny-avila e2c4725
fix(code): preserve drained cancellation fences
danny-avila 9a30d8f
fix(code): Fall back from invalid workspace names
danny-avila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
--worker-dirpoints to a valid directory whose basename is whitespace-only or longer thanBRIDGE_WORKSPACE_NAME_MAX_LENGTH(for example, a 129-character Linux directory name), this default is passed as the workspace name andLocalWorkspaceTools.createrejects the registration. In this head the fallback only handles an empty basename, so these directories still require an otherwise unnecessary explicit--workspace-name; validate the derived basename and fall back to the workspace ID when it cannot be advertised.Useful? React with 馃憤聽/ 馃憥.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4ccea0df. Automatically derived workspace names are now accepted only when non-whitespace and within the protocol length limit; otherwise the CLI advertises the configured workspace ID. Explicit invalid names still fail validation. The package suite passes all 142 tests, including a real whitespace-named directory registration regression.