Repository navigation
feat(validation): support drag-and-drop PDF upload on the Validation page - #7924
Conversation
…page Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
vitormattos
left a comment
There was a problem hiding this comment.
Could you also provide screenshot or demo video?
|
Codecov Report❌ Patch coverage is
... and 172 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Congratulations on the initiative and your contribution to the project. How did you find out about LibreSign? |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
Added the TRANSLATORS hints for the drop-zone text and the Upload button, and kept the existing UUID note as-is (matches your suggestion). Pushed in 4e06d33. On the demo: the drag-and-drop area sits above the existing "From UUID"/"Upload" buttons on the Validation page. Dragging a PDF over it highlights the zone ( Found LibreSign while looking for a self-hosted Nextcloud-based signing app. |
|
Thanks for taking a look. I came across LibreSign while looking for a self-hostable, open-source document-signing option that integrates with Nextcloud, and the Validation page stood out as a place where drag-and-drop would smooth out the upload flow. On the demo: the change lets you drop a PDF anywhere on the Validation drop zone (in addition to the existing file picker). The drop zone shows an active/hover state while a file is dragged over it, rejects non-PDF files with the same validation the picker uses, and then runs the same validation request as a picker upload. I'll add a short screen recording of the drag-and-drop flow to the PR shortly. |
|
Thanks @SAY-5 ! Sounds great to me: Screencast.From.2026-07-21.15-16-11.mp4I don't have any suggestions for improving the code. From what I've read, only one implementation of the code suggestion is still pending. |
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Signed-off-by: Vitor Mattos <vitor@php.rio>
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/7924/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7adf8704 4e06d339 5e87b3db 93c9e7a5 8cbbefd8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7924/stable32Error: Failed to push branch backport/7924/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
Resolves: #7923
📝 Summary
The Validation page only accepted a PDF through the Upload button. Users often expect the upload area to also accept a dragged file, and during testing a dropped PDF did nothing. This adds drag-and-drop over the upload area, reusing the existing validate flow. The Upload and From UUID buttons keep working as before.
🧪 How to test
🎨 UI / Front‑end changes
🚧 Tasks
✅ Checklist
🤖 AI (if applicable)