Repository navigation
[stable35] fix(rejection): notify the next signing order only after the commit - #9037
Closed
backportbot-libresign[bot] wants to merge 4 commits into
Closed
backportbot-libresign[bot] wants to merge 4 commits into
backportbot-libresign[bot] wants to merge 4 commits into
Conversation
A rejection that lets the workflow continue releases the next signing order inside its transaction. releaseNextOrder() persisted ABLE_TO_SIGN and dispatched the notification in the same method, so on an envelope with several documents the signers released for an earlier document were already notified when a later document failed and rolled the transaction back: the message was delivered for an activation that no longer existed. activateSignersForOrder() now only persists the state and returns the signers it activated. activateNextOrder() exposes that for callers that run inside a transaction and notifyActivatedSigners() dispatches the notifications, which SignatureRejectionService calls after commit(). releaseNextOrder() keeps activating and notifying in one step, so the non-transactional callers are unchanged, and a failing listener can no longer undo a recorded rejection. Signed-off-by: Turgay Nalbant <182372382+tnalbant@users.noreply.github.com>
Every signer/identify-method notification is isolated: a failed delivery is logged with the sign request id and the identify method, and the remaining activated signers are still notified instead of being skipped. The post-commit catch in SignatureRejectionService now catches recoverable exceptions (\Exception) instead of \Throwable, so programming errors are not converted into a logged delivery failure; the log includes the sign request id. Adds regression tests for both behaviours. Signed-off-by: Turgay Nalbant <182372382+tnalbant@users.noreply.github.com>
Keep recoverable notification failures in SequentialSigningService, extract per-signer delivery, and preserve rollback assertions. Adapt identification lookup isolation from PR #8948 while keeping rejection event ordering for that follow-up PR. Co-authored-by: André Maia <andrefnkmm@gmail.com> Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
fix(rejection): dispatch rejection event before signer notifications Return activated signers after committing the rejection and dispatch SignatureRejectedEvent before attempting their notifications. Preserve event delivery when a post-commit notification error propagates. Adapt the event-ordering correction from PR #8948 and strengthen the successful-order and notification-error regression assertions. Co-authored-by: André Maia <andrefnkmm@gmail.com> Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci]
Member
|
Closing this backport because #8912 is not independently applicable to stable35. The fix in #8912 assumes the rejection "continue" behavior introduced on main by #8423/#8706, including The automatic cherry-pick therefore produced an invalid partial backport: it references Backporting #8912 alone would effectively require backporting the unreleased rejection-policy/continue feature chain, which is outside the scope of this bugfix. The same prerequisite is absent from stable34 and stable33, which is why the bot correctly found no applicable changes there. No backport of #8912 is needed for stable35/stable34/stable33. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8912
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.