Skip to content

test(sequential-signing): cover parallel activation - #9040

Closed
vitormattos wants to merge 1 commit into
mainfrom
follow-up/8948-parallel-activation-test
Closed

vitormattos wants to merge 1 commit into
mainfrom
follow-up/8948-parallel-activation-test

Conversation

@vitormattos

@vitormattos vitormattos commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Reconciles the remaining distinct test coverage from #8948 against current main after #8912 merged the production fix.

Preserved from André Maia's contribution:

  • activateNextOrder() returns no activated signers for parallel flows and performs no sign-request lookup;
  • every identify-method group of every activated signer is notified.

The production changes and the remaining rejection/notification tests from #8948 already have equivalent or stronger coverage in main through #8912. André Maia remains credited as co-author of this reconciliation commit.

Related: #8948, #8912

Preserve the direct parallel-flow coverage from #8948 after #8912
superseded the production changes in that pull request.

Co-authored-by: André Maia <andrefnkmm@gmail.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Copy link
Copy Markdown
Member Author

Closing this temporary follow-up. After a deeper review, #8948 has been reopened and will remain the place where André Maia's remaining work is reconciled against current main. Keeping this PR open would split that work across two pull requests.

@vitormattos vitormattos closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant