Repository navigation
test(sequential-signing): cover parallel activation - #9040
Closed
vitormattos wants to merge 1 commit into
Closed
vitormattos wants to merge 1 commit into
vitormattos wants to merge 1 commit into
Conversation
4 tasks done
Member
Author
|
Closing this temporary follow-up. After a deeper review, #8948 has been reopened and will remain the place where André Maia's remaining work is reconciled against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles the remaining distinct test coverage from #8948 against current
mainafter #8912 merged the production fix.Preserved from André Maia's contribution:
activateNextOrder()returns no activated signers for parallel flows and performs no sign-request lookup;The production changes and the remaining rejection/notification tests from #8948 already have equivalent or stronger coverage in
mainthrough #8912. André Maia remains credited as co-author of this reconciliation commit.Related: #8948, #8912