Repository navigation
test(sequential-signing): preserve additional #8948 coverage - #9041
Merged
Merged
Conversation
With `rejection_behavior = continue`, a rejection releases the next signing order of every document it closes inside one transaction. `SequentialSigningService::releaseNextOrder()` notified each released signer right away, so when a later document of an envelope failed and the transaction rolled back, the signer had already been told that a document was ready to sign. `activateNextOrder()` now performs only the state change and returns the signers it activated, and `notifyActivatedSigners()` sends their notifications. `releaseNextOrder()` calls both, so the signing flow and `reorderAfterDeletion()` keep their behavior. The rejection collects the released signers and notifies them after the commit. `notifyActivatedSigners()` owns the delivery error policy: each signer is notified by `notifySigner()`, which isolates every identify method, so one failed delivery does not keep the remaining signers, already able to sign, from being told. Only `\Exception` is isolated and logged with the sign request and identify method; an `\Error` is a programming error and stays visible. Resolves: #8803 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: André Maia <andrefnkmm@gmail.com>
…d signers Notifying the signers released by a rejection runs after the commit, so nothing raised there may turn a recorded rejection into an error. Two gaps remained: - `SequentialSigningService::notifySigner()` loaded the identify methods outside the isolated delivery, so an exception from that lookup (a lost database connection, for example) escaped `reject()`. The signer got an error for a rejection that was already saved and could not retry. - `reject()` notified the released signers before dispatching `SignatureRejectedEvent`, so an error while notifying skipped the event. The lookup is now isolated and logged like a failed delivery, and the remaining signers are still notified. `persistRejection()` returns the released signers and `reject()` dispatches the event before notifying them. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: André Maia <andrefnkmm@gmail.com>
Cherry-pick the remaining applicable coverage from André Maia's 0eb8da9 after resolving it against #8912, which already merged the production changes and overlapping tests. Cherry-picked-from: 0eb8da9 Co-authored-by: André Maia <andrefnkmm@gmail.com> Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Preserve the remaining applicable coverage from André Maia's #8948 series after resolving the follow-up against current main. The production fixes and error-ordering changes from 7cee8ff are already present through #8912, so only the distinct notification coverage remains to apply. Cherry-picked-from: 7cee8ff Co-authored-by: André Maia <andrefnkmm@gmail.com> Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
follow-up/8948-reconcile
branch
from
October 6, 2026 15:23
25b370e to
a800b90
Compare
4 tasks done
YvesCesar
approved these changes
Oct 15, 2026
Preserve the original commits from #8948 as ancestors of this merge while reconciling the branch with current main and the focused tests from #9041. The production fix and overlapping tests remain as integrated by #8912; the diff against main consists exclusively of the 38 additional test lines from #9041. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles the remaining distinct test coverage from #8948 against current
mainafter #8912 merged the production fix.Preserved from André Maia's contribution:
activateNextOrder()returns no activated signers for parallel flows and performs no sign-request lookup;The production changes and the remaining rejection/notification tests from #8948 already have equivalent or stronger coverage in
mainthrough #8912. André Maia remains credited as co-author of this reconciliation commit.Related: #8948, #8912