test: align PageController and validation page tests with the sanitized validation payload

[maia-andre]

📝 Summary

Since the validation page security fixes landed on main (20d806a, 37d92dd), every pull request against main fails the same two checks, whatever it changes:

• PHPUnit (all databases, all PHP versions): the 11 PageControllerTest cases fail with ArgumentCountError: PageController::__construct(): Argument #10 ($validationEffectivePolicyService) not passed.
• Node tests: Validation.spec.ts > handleValidationSuccess > updates the policies store when requester effective policies are returned still expects setPolicies, which the page no longer calls.

This PR only updates those tests to the new contract. No production code changes.

• PageControllerTest passes a real ValidationEffectivePolicyService (the class is final) built around the PolicyService mock each test already configures. The public validation case now also asserts the policy payload the page receives (['policies' => []] when there is no legal information), instead of only checking that the key exists.
• Validation.spec.ts checks that the legal information returned with the validation is shown and that the global policy store is not touched, which is the intent of 37d92dd.

🧪 How to test

composer test:integration -- --filter PageControllerTest
npx vitest run src/tests/views/Validation.spec.ts

Validation evidence

• Focused regression test: PageControllerTest 11/11 (was 11 errors on main, e.g. the PHPUnit jobs of test(appstore): cover the release Nextcloud setup and validate the unsigned package #9063); Validation.spec.ts 100/100 (was 1 failure)
• Relevant lint checks: eslint on the spec, php -l on the test
• CI reviewed

✅ Checklist

• I have read and followed the contribution guide.
• The diff does not contain unrelated refactors or generated changes.
• Commits follow Conventional Commits where applicable.
• All commits include the required DCO sign-off.

🤖 AI (if applicable)

• The content of this PR was partially or fully generated using AI

[maia-andre]

@vitormattos @YvesCesar could one of you take a look when you have a moment? Since the validation-page security fix, main fails PageControllerTest and Validation.spec.ts, so the PHPUnit matrix is red on every open PR (e.g. #9063). This PR only aligns those tests with the sanitized validation payload; CI is green.

[YvesCesar]

Thanks @maia-andre !

I wrote a review. Could you take a look at it?

[YvesCesar]

The view Validation.vue no longer imports store/policies (neither do its child components, and the spec uses shallowMount), so setPolicies can never be called here. This assertion always passes and doesn't protect anything from 37d92dd.

Please remove:

• this assertion and the usePoliciesStore lookup at the top of the test (lines 1078-1079);
• the vi.mock('../../store/policies', ...) block at line 187, which is only used by this test.

The legalInformation assertion is enough to cover the new behavior.