Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Signed-off-by: oPeras1 <hugo.pereira@rnl.tecnico.ulisboa.pt>
oPeras1
force-pushed
the
fix/validation-open-signed-pdf
branch
from
October 17, 2026 20:34
25f1d8c to
73d761e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #9103
📝 Summary
On the validation page, "Open file" / "View PDF" passed the file owner's original
nodeIdtoOCA.Viewerfor logged-in users. Viewer handlers that resolvefileidin the current user's filesystem (Euro-Office, ONLYOFFICE) then:{"error":"File not found"}for signers and other logged-in users.This PR makes the validation page always open the signed PDF by UUID (
/apps/libresign/p/pdf/<uuid>), as it already does for anonymous visitors.openDocumentnow only usesOCA.Viewerwhen anodeIdis explicitly given, so other callers (Files list, sidebar, ID docs, settings) are unchanged.The change is frontend only. The backend route already resolves the storage owner from the UUID and serves the signed file.
🧪 How to test
/apps/libresign/validation/<uuid>and click "Open file":Validation evidence
🎨 UI / Front-end changes
main. The Viewer picks its handler by MIME type, and some handlers need a node the user can access, so it can't be used safely here.EnvelopeValidation, "View PDF" is shown when a file has auuid, instead of requiringnodeId.🚧 Tasks
✅ Checklist
🤖 AI (if applicable)