Repository navigation
[stable34] fix: apply signer removal to every document in an envelope - #9115
Merged
Merged
Conversation
Backport the Behat cancellation scenarios from #9101, including removal from child documents, last signer cleanup, and notification counts. Original contribution by Carlo Marmo in #9101. Co-authored-by: Carlo Marmo <carlo.marmo@gmail.com> Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
marked this pull request as ready for review
October 20, 2026 01:18
vitormattos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the signer-removal fix from #9101 to
stable34.Deleting a signer from an envelope previously left signing requests in child documents because the identification methods were deleted before propagation. This brings the same production fix and Behat regression coverage to stable34, including one cancellation notification per envelope and unchanged direct child notification behavior.
Scope
lib/Service/RequestSignatureService.php: preserve identification methods before deleting, propagate to children, avoid duplicate cancellation events.tests/integration/features/sign/cancel.feature: regression scenarios for removing one of two signers, removing the last signer, and directly removing a child signer.Origin and validation
git apply --checkagainststable34locally.The original #9101 has been merged into
main(merge commitfb0b96f31fc7). Keep this backport draft until its own CI and review pass. No automatic merge.