Skip to content

Enforce Agent Skills name validation on the sync write path, not only under --validate #221

Description

@sebastientaggart

Follow-up auto-proposed from the code review on PR #220.

Original finding:

[WARNING] Spec-name validation runs only under --validate; the write path and CI's --dry-run don't catch a frontmatter-name/directory mismatch, so noncompliant output could ship to consumer repos undetected.

Failure scenario: a skill's frontmatter name is renamed without renaming its directory (or vice versa) — sync_skill silently writes output under fm['name'], CI's ./sync.py --dry-run passes, and name/directory-mismatched output lands in every consumer repo until someone manually runs --validate.

Possible directions (to be decided at implementation time): run validate_skill_names as part of the normal sync/dry-run path, or add --validate to the CI sync-check workflow alongside --dry-run.

See the review comment thread on #220 for context.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions