Skip to content

fix: prevent duplicate teamspace entries in _list_available_teamspaces - #164

Open
deependujha wants to merge 2 commits into
Lightning-AI:mainfrom
deependujha:fix/duplicate-teamspace-entries
Open

deependujha wants to merge 2 commits into
Lightning-AI:mainfrom
deependujha:fix/duplicate-teamspace-entries

Conversation

@deependujha

Copy link
Copy Markdown
Contributor
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha changed the title fix: prevent duplicate teamspace entries in _list_available_teamspaces fix: prevent duplicate teamspace entries in _list_available_teamspaces Sep 25, 2026

@ethanwharris ethanwharris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that we need to interact with such low-level / private SDK things here. Will cause issues if the SDK changes internally. Might be worth seeing if a lot of this can just be pulled out

@deependujha

deependujha commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

@ethanwharris ig it might be due to this.

image

same teamspace is shown for both User Org & Personal teamspace. It makes sense for CLI to directly handle this and return the list.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 83%. Comparing base (d3e3247) to head (bcbd653).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #164   +/-   ##
===================================
- Coverage    84%    83%   -1%     
===================================
  Files        12     12           
  Lines       511    516    +5     
===================================
  Hits        430    430           
- Misses       81     86    +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants