fix: support loading .pth models - #165
Open
deependujha wants to merge 2 commits into
Open
deependujha wants to merge 2 commits into
deependujha wants to merge 2 commits into
Conversation
deependujha
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
September 25, 2026 08:17
ethanwharris
approved these changes
Sep 25, 2026
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
===================================
- Coverage 84% 84% -0%
===================================
Files 12 12
Lines 511 513 +2
===================================
Hits 430 430
- Misses 81 83 +2 🚀 New features to boost your workflow:
|
justusschock
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
The README documents saving and loading PyTorch models, but
.pthartifacts currently fail withNotImplementedErrorduring loading.Use
torch.load(..., weights_only=False)to support loading.pthartifacts containing serialized model objects and ensure theREADME's save/load example works as documented.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃