fix(cli): render created_at strings from the API in vm list - #155
Merged
Merged
Conversation
(cherry picked from commit a4ac612)
klayton-vp
requested review from
ethanwharris,
justusschock,
k223kim and
rusenask
as code owners
September 15, 2026 16:07
ethanwharris
approved these changes
Sep 15, 2026
daniela-veloz-lai
approved these changes
Sep 15, 2026
robTheBuildr
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lightning vm listcrashed against production with'str' object has no attribute 'strftime': the API returnscreated_atas an ISO string even though the generatedV1Instancemodel declares a datetime, and the unit test never set the field.The Created column now accepts either a datetime or a string. Test covers both forms.
Found while running the create, list, ssh, delete loop end to end on a machine cluster; everything else in #148 worked as expected.