feat(SDK): use writer instead of target_path for activity - #165
Merged
Merged
Conversation
bmaydan
requested review from
dhedey,
ethanwharris,
justusschock,
k223kim,
owbone,
rusenask and
tejapulagam
as code owners
September 17, 2026 19:54
bmaydan
force-pushed
the
ben/billing-activity
branch
from
September 17, 2026 20:01
bbb5ddb to
39fbb3d
Compare
bmaydan
changed the title
bmaydan
enabled auto-merge (squash)
September 18, 2026 12:28
owbone
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_pathwithwriter(any writable text stream) acrossBillingApi.get_session_activity,get_resource_activity,_get_activity_report, and theOrganizationwrappers._download_activity_csvnow returns the CSV text directly, and_get_activity_reportparses it in memory instead of writing to a temp file, converting, then deleting it.ActivityFileFormatfromlightning_sdk/__init__.pyand updated docs to use flat class names instead of fully-qualified paths.https://www.loom.com/share/ff75977a541d422a88b18f8018130f49