feat(studio): add bounded override persistence controls - #12
Open
bakasura980 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR adds bounded and indefinite override-persistence controls, persistence-aware scenario serialization, and cancellation attempts during action or scenario deletion.
Confidence Score: 3/5
The PR is not yet safe to merge because the backend ignores the new persistence contract and the missing-template edit transition can still restore stale action state.
The current Surfpool backend has neither the persisted override field nor the cancellation RPC used by the UI, while one edit-selection path still leaves an earlier account request current after the editing target changes.
Files Needing Attention: apps/studio/src/lib/scenarios-api.ts, apps/studio/src/components/svm/scenario-editor.tsx, apps/studio/src/components/svm/scenarios-bento.tsx
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Editor[Persistence controls] --> Save[Scenario PATCH] Editor --> Play[surfnet_registerScenario] Save --> Backend[Surfpool backend] Play --> Backend Editor --> Stop[surfnet_stopPersistingOverride] Stop --> BackendComments Outside Diff (1)
apps/studio/src/components/svm/scenario-editor.tsx, line 1435-1438 (link)When action A has a pending account request and the user clicks persisted action B whose template is absent from the current catalog,
editingActionchanges without callinghandleActionSelectorcancelActionSelection. A's request therefore remains current and restores its overrides and persistence controls into B's editing position, so updating B saves A's stale state.Knowledge Base Used: Studio scenarios and AI workflows
Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (4): Last reviewed commit: "fix(studio): include PDA values when sto..." | Re-trigger Greptile
Context used: