[TransferEngine] Rebuild single Jetty on ACK timeout (status=9) - #33
Open
Connor-Matthew wants to merge 4 commits into
Open
[TransferEngine] Rebuild single Jetty on ACK timeout (status=9)#33Connor-Matthew wants to merge 4 commits into
Connor-Matthew wants to merge 4 commits into
Conversation
Avoid deleting the whole endpoint after a transient ACK timeout by draining the faulty Jetty, recreating it locally, and rebinding to the existing peer id. Falls back to deleteEndpoint on flush-done timeout or rebuild failure. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
documentation
Mark the jetty rebuild design doc as Sphinx orphan and apply clang-format to the UrmaEndpoint changes so PR checks pass. Co-authored-by: Cursor <cursoragent@cursor.com>
Defer endpoint deletion until after poll depth accounting to avoid UAF, deliver flush completions during rebuild, and isolate stale CQEs with per-slot jetty epochs. Align disconnect teardown with ERROR flush fence constraints and document the updated rebuild accounting model. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
status=9（
URMA_CR_ACK_TIMEOUT_ERR）时，不再很快把整条 endpoint 删掉，而是对本端故障 Jetty 做：modify(ERROR)排空FLUSH_ERR_DONEflush→ unbind/unimport → delete → create → 本端 re-import/rebind 原对端 jetty id纯本地恢复，不引入对端同步协议。flush-done 超时（默认 3s）或重建失败则回退
deleteEndpointByPtr。设计说明：
docs/source/design/transfer-engine/jetty-single-rebuild-plan.mddocs/source/design/transfer-engine/jetty-ack-timeout-rebuild.mdModule
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
# 需在带 UMDK / 真实 UB 的服务器上验证 status=9 注入与恢复Test results:
本机无 liburma，无法在此完成硬件路径验证。请在服务器上验证：
Checklist
./scripts/code_format.sh