[TransferEngine] Port URMA NUMA affinity mode - #35
Open
Connor-Matthew wants to merge 7 commits into
Open
Conversation
Re-add client_buffer.h so calculate_total_size and split_into_slices remain visible in client_service.cpp after the URMA port cleanup. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace supercache-only MC_LOG calls with LOG(INFO/ERROR) so real_client.cpp builds under main's mooncake-store logging. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply code_format.sh to the LOG calls added for URMA NUMA setup so CI format checks pass before build jobs run. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ports the final net changes from LinQuickDev/Mooncake#18 onto the current
mainbranch.The changes add URMA/UB NUMA affinity and multipath support while preserving the current
mainbranch logic.This PR is intended for internal CI validation and code review only. Please do not merge this PR.
Module
mooncake-transfer-engine)mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
git diff --check cmake -S . -B build \ -DBUILD_UNIT_TESTS=ON \ -DWITH_STORE=OFF \ -DWITH_STORE_RUST=OFF \ -DWITH_EP=OFF \ -DUSE_UB=OFF \ -DUSE_RDMA=OFF \ -DUSE_CUDA=OFFTest results:
git diff --checkpassed.numa.h; they were not completed locally on macOS.Checklist
./scripts/code_format.sh